filter out hidden elements when copying code#13256
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces regex-based text filtering in the CopyButton component with a DOM-based approach that removes elements marked as hidden. Review feedback identifies a potential compilation error where the remove method is called on a generic Node type and suggests optimizing the node iterator to target elements specifically. It also notes that the newly added js_interop import would become redundant if these suggestions are adopted.
Collaborator
|
Visit the preview URL for this PR (updated for commit 2511c9c): https://flutter-docs-prod--pr13256-fix-copy-no-hidden-wcg56xbe.web.app |
sfshaza2
approved these changes
Apr 7, 2026
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
LGTM, but I will leave it to you to resolve the bot's complaints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13253
Presubmit checklist
of 80 characters or fewer.